MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.57k stars 4.73k forks source link

feat: update push notification API request/response #24542

Closed Prithpal-Sooriya closed 1 week ago

Prithpal-Sooriya commented 2 weeks ago

Description

Push Notification API update. We now support a platform field with the registration tokens. This allows better push notification support between our different platforms.

Open in GitHub Codespaces

Related issues

Fixes: N/A

Manual testing steps

This has no impact. The notification feature is not released yet.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions[bot] commented 2 weeks ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 67.37%. Comparing base (4cf7e80) to head (ced01f5).

Files Patch % Lines
...s/push-platform-notifications/services/services.ts 0.00% 9 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #24542 +/- ## =========================================== - Coverage 67.37% 67.37% -0.00% =========================================== Files 1289 1289 Lines 50220 50222 +2 Branches 13005 13007 +2 =========================================== Hits 33835 33835 - Misses 16385 16387 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

metamaskbot commented 1 week ago
Builds ready [ced01f5]
Page Load Metrics (1109 ± 553 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6412795178
domContentLoaded9261342
load51262311091153553
domInteractive9261342
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 84 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)