github-actions[bot]
commented
2 weeks ago CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
Closed albertolive closed 1 week ago
github-actions[bot]
commented
2 weeks ago CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
albertolive
commented
2 weeks ago @metamaskbot update-policies
metamaskbot
commented
2 weeks ago Policies updated
metamaskbot
commented
2 weeks ago | Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
|---|---|---|---|---|---|---|---|
| Chrome | Home | firstPaint | 59 | 159 | 95 | 24 | 11 |
| domContentLoaded | 9 | 32 | 17 | 7 | 3 | ||
| load | 55 | 2593 | 763 | 1062 | 510 | ||
| domInteractive | 9 | 32 | 17 | 7 | 3 |
metamaskbot
commented
2 weeks ago | Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
|---|---|---|---|---|---|---|---|
| Chrome | Home | firstPaint | 56 | 137 | 91 | 21 | 10 |
| domContentLoaded | 8 | 38 | 17 | 11 | 5 | ||
| load | 45 | 2256 | 661 | 908 | 436 | ||
| domInteractive | 8 | 38 | 17 | 11 | 5 |
albertolive
commented
1 week ago @metamaskbot update-policies
metamaskbot
commented
1 week ago Policies updated
socket-security[bot]
commented
1 week ago New dependencies detected. Learn more about Socket for GitHub ↗︎
| Package | New capabilities | Transitives | Size | Publisher |
|---|---|---|---|---|
| npm/@gar/promisify@1.1.3 | None | 0 |
4.2 kB | gar |
| npm/@npmcli/move-file@2.0.1 | filesystem | 0 |
8.73 kB | gar |
| npm/aproba@1.2.0 | None | 0 |
8.18 kB | iarna |
| npm/are-we-there-yet@3.0.1 | None | 0 |
14.3 kB | lukekarrys |
| npm/console-control-strings@1.1.0 | None | 0 |
12.7 kB | iarna |
| npm/detect-libc@1.0.3 | environment, filesystem, shell | 0 |
17.2 kB | lovell |
| npm/gauge@4.0.4 | None | 0 |
43.2 kB | gar |
| npm/has-unicode@2.0.1 | environment | 0 |
3.44 kB | iarna |
| npm/ignore-walk@3.0.1 | filesystem | 0 |
10.8 kB | isaacs |
| npm/infer-owner@1.0.4 | filesystem | 0 |
4.29 kB | isaacs |
| npm/needle@2.4.0 | filesystem, network | 0 |
199 kB | tomas |
| npm/node-pre-gyp@0.12.0 | environment, filesystem | +7 |
400 kB | nicolasnoble |
| npm/npm-bundled@1.1.2 | filesystem | 0 |
9.74 kB | isaacs |
| npm/npm-packlist@1.4.8 | None | +1 |
144 kB | isaacs |
| npm/npmlog@4.1.2 | None | +2 |
80.4 kB | iarna |
| npm/os-tmpdir@1.0.2 | None | 0 |
3.06 kB | sindresorhus |
| npm/osenv@0.1.5 | environment, shell | 0 |
4.89 kB | isaacs |
| npm/sax@1.3.0 | None | 0 |
55 kB | isaacs |
| npm/wide-align@1.1.5 | None | 0 |
4.47 kB | iarna |
socket-security[bot]
commented
1 week ago 🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎
To accept the risk, merge this PR and you will not be notified again.
| Alert | Package | Note |
|---|---|---|
| Shell access | npm/detect-libc@1.0.3 |
|
| Deprecated | npm/npmlog@4.1.2 |
|
| Deprecated | npm/are-we-there-yet@1.1.7 |
|
| Deprecated | npm/gauge@2.7.4 |
|
| Deprecated | npm/osenv@0.1.5 |
|
| Shell access | npm/osenv@0.1.5 |
|
| Deprecated | npm/@npmcli/move-file@2.0.1 |
|
| Deprecated | npm/are-we-there-yet@3.0.1 |
|
| New author | npm/are-we-there-yet@3.0.1 |
|
| Deprecated | npm/gauge@4.0.4 |
|
| Network access | npm/needle@2.4.0 |
|
| Network access | npm/needle@2.4.0 |
|
| Deprecated | npm/node-pre-gyp@0.12.0 |
|
| New author | npm/node-pre-gyp@0.12.0 |
|
This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.
Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.
The maintainer of the package marked it as deprecated. This could indicate that a single version should not be used, or that the package is no longer maintained and any new vulnerabilities will not be fixed.
Research the state of the package and determine if there are non-deprecated versions that can be used, or if it should be replaced with a new, supported solution.
A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.
Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.
This module accesses the network.
Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.
Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.
If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.
To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all
@SocketSecurity ignore npm/detect-libc@1.0.3@SocketSecurity ignore npm/npmlog@4.1.2@SocketSecurity ignore npm/are-we-there-yet@1.1.7@SocketSecurity ignore npm/gauge@2.7.4@SocketSecurity ignore npm/osenv@0.1.5@SocketSecurity ignore npm/@npmcli/move-file@2.0.1@SocketSecurity ignore npm/are-we-there-yet@3.0.1@SocketSecurity ignore npm/gauge@4.0.4@SocketSecurity ignore npm/needle@2.4.0@SocketSecurity ignore npm/node-pre-gyp@0.12.0metamaskbot
commented
1 week ago | Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
|---|---|---|---|---|---|---|---|
| Chrome | Home | firstPaint | 66 | 169 | 97 | 28 | 13 |
| domContentLoaded | 9 | 53 | 18 | 13 | 6 | ||
| load | 53 | 2678 | 773 | 1075 | 516 | ||
| domInteractive | 9 | 53 | 18 | 13 | 6 |
albertolive
commented
1 week ago @metamaskbot update-policies
metamaskbot
commented
1 week ago No policy changes
metamaskbot
commented
1 week ago | Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
|---|---|---|---|---|---|---|---|
| Chrome | Home | firstPaint | 71 | 434 | 122 | 77 | 37 |
| domContentLoaded | 10 | 35 | 15 | 8 | 4 | ||
| load | 58 | 2804 | 1369 | 1184 | 568 | ||
| domInteractive | 10 | 35 | 15 | 8 | 4 |
zone-live
commented
1 week ago @metamaskbot update-policies
metamaskbot
commented
1 week ago Policies updated
metamaskbot
commented
1 week ago | Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
|---|---|---|---|---|---|---|---|
| Chrome | Home | firstPaint | 71 | 147 | 98 | 26 | 12 |
| domContentLoaded | 9 | 40 | 13 | 7 | 3 | ||
| load | 59 | 2457 | 913 | 1040 | 499 | ||
| domInteractive | 9 | 40 | 13 | 7 | 3 |
Description
Updated MMI packges
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist