cherry-pick: fix newline display in signature request content - Githubissues

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites

https://metamask.io

Other

11.57k stars 4.73k forks source link

cherry-pick: fix newline display in signature request content #24553

Closed jpuri closed 1 week ago

jpuri commented 2 weeks ago

Description

Newline is not preserved in re-designed signature pages.

Related issues

Fixes: https://github.com/MetaMask/metamask-extension/issues/24480

Manual testing steps

To to test DAPP
Submit a signature request with new lines
Ensure that new lines are preserved

Screenshots/Recordings

Screenshot 2024-05-13 at 4 20 06 PM

Pre-merge author checklist

[X] I’ve followed MetaMask Coding Standards.
[X] I've completed the PR template to the best of my ability
[X] I’ve included tests if applicable
[ ] I’ve documented my code using JSDoc format if applicable
[X] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

[ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
[ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions[bot] commented 2 weeks ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot commented 1 week ago

No release label on PR. Adding release label release-11.17.0 on PR, as PR was cherry-picked in branch 11.17.0.