search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
12.03k stars 4.91k forks source link

[Bug]: MM crashes during confirmations with some currencies #24558

Closed bschorchit closed 5 months ago

bschorchit commented 5 months ago

Describe the bug

MM crashes if user selects a currency that is not supported by the token api and starts a transaction that has simulation.

Expected behavior

Not crashing and displaying "Not available" if we're not able to get a conversion.

Screenshots/Recordings

image

Steps to reproduce

  1. Go to Settings > General
  2. Change your currency to Storj
  3. Start a send transaction on Ethereum with any value
  4. Notice MM crash

The only way to recover from the crash is to disable and re-enable MM and changing the network before unlocking it otherwise you'll consistently unlock it and arrive at the crashed screen

Error messages or log output

No response

Version

11.15.2

Build type

None

Browser

Brave

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

benjisclowder commented 4 months ago

Collaborative Effort Required for Root Cause Analysis (RCA) on Critical Issues

We are quickly approaching the end of the quarter and we encourage you once again to take some moments and perform RCA on this critical issue. You may do so by answering the questions below:

What PR fixed the issue? Can you pinpoint the commit from which the issue originated? Write a short explanation of the technical cause of the bug How could we have avoided merging this bug? What would have had to be different about our code, tests or processes? 4.1. Were there any missing unit, e2e or manual tests that could have preempted this issue? 4.2. Were there any other elements lacking, such as typed code, comprehensive documentation, well-architected APIs, etc., that might have prevented this issue? 4.3. If your answer to a and b is no, then is there anything at all that you can think of that, if it had been different before this bug was introduced, would have prevented it from being merged? Please provide your answers as a reply to this comment and tag me as well.

You can read more about the initiative here. Thank you!

Tagging eng. who added the fix: @OGPoyraz

OGPoyraz commented 4 months ago

Collaborative Effort Required for Root Cause Analysis (RCA) on Critical Issues

We are quickly approaching the end of the quarter and we encourage you once again to take some moments and perform RCA on this critical issue. You may do so by answering the questions below:

What PR fixed the issue? Can you pinpoint the commit from which the issue originated? Write a short explanation of the technical cause of the bug How could we have avoided merging this bug? What would have had to be different about our code, tests or processes? 4.1. Were there any missing unit, e2e or manual tests that could have preempted this issue? 4.2. Were there any other elements lacking, such as typed code, comprehensive documentation, well-architected APIs, etc., that might have prevented this issue? 4.3. If your answer to a and b is no, then is there anything at all that you can think of that, if it had been different before this bug was introduced, would have prevented it from being merged? Please provide your answers as a reply to this comment and tag me as well.

You can read more about the initiative here. Thank you!

Tagging eng. who added the fix: @OGPoyraz

What PR fixed the issue?

Can you pinpoint the commit from which the issue originated?

Write a short explanation of the technical cause of the bug

How could we have avoided merging this bug? What would have had to be different about our code, tests or processes? 4.1. Were there any missing unit, e2e or manual tests that could have preempted this issue?

4.2. Were there any other elements lacking, such as typed code, comprehensive documentation, well-architected APIs, etc., that might have prevented this issue?

@benjisclowder fyi