Closed pnarayanaswamy closed 1 week ago
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.
Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
---|---|---|---|---|---|---|---|
Chrome | Home | firstPaint | 69 | 177 | 103 | 32 | 15 |
domContentLoaded | 9 | 80 | 18 | 15 | 7 | ||
load | 56 | 2546 | 1083 | 1122 | 539 | ||
domInteractive | 9 | 80 | 18 | 15 | 7 |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 67.37%. Comparing base (
576670f
) to head (141a1fe
). Report is 1 commits behind head on develop.:exclamation: Current head 141a1fe differs from pull request most recent head 31eb4ce
Please upload reports for the commit 31eb4ce to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Platform | Page | Metric | Min (ms) | Max (ms) | Average (ms) | StandardDeviation (ms) | MarginOfError (ms) |
---|---|---|---|---|---|---|---|
Chrome | Home | firstPaint | 63 | 130 | 89 | 20 | 10 |
domContentLoaded | 9 | 45 | 13 | 8 | 4 | ||
load | 49 | 2429 | 730 | 1019 | 490 | ||
domInteractive | 9 | 45 | 13 | 8 | 4 |
Description
Fixes the bug where the ui_customization property does not show up in the metrics event. Also fixed the mapping such that the ui_customization property shows up for the eth_signTypedData as well.
Related issues
Fixes: #24578
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist