MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.57k stars 4.73k forks source link

fix: use correct property name for redesign #24579

Closed pnarayanaswamy closed 1 week ago

pnarayanaswamy commented 2 weeks ago

Description

Fixes the bug where the ui_customization property does not show up in the metrics event. Also fixed the mapping such that the ui_customization property shows up for the eth_signTypedData as well.

Open in GitHub Codespaces

Related issues

Fixes: #24578

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions[bot] commented 2 weeks ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot commented 2 weeks ago
Builds ready [141a1fe]
Page Load Metrics (1083 ± 539 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint691771033215
domContentLoaded98018157
load56254610831122539
domInteractive98018157
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 57 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)
codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.37%. Comparing base (576670f) to head (141a1fe). Report is 1 commits behind head on develop.

:exclamation: Current head 141a1fe differs from pull request most recent head 31eb4ce

Please upload reports for the commit 31eb4ce to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #24579 +/- ## ======================================== Coverage 67.37% 67.37% ======================================== Files 1289 1289 Lines 50219 50219 Branches 13005 13005 ======================================== Hits 33834 33834 Misses 16385 16385 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

metamaskbot commented 2 weeks ago
Builds ready [31eb4ce]
Page Load Metrics (730 ± 490 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint63130892010
domContentLoaded9451384
load4924297301019490
domInteractive9451384
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -18 Bytes (-0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 89 Bytes (0.00%)