[Bug]: Send and swap flow for unsupported networks

sleepytanya commented 3 months ago

Describe the bug

In the context of the send+swap flow on unsupported networks, considering the substantial user base operating within these networks, introducing a notification system or potentially disabling this feature for networks beyond the mainnet and BNB might significantly improve the user experience. Currently, when users on unsupported networks attempt to use the send+swap feature, they are allowed to select a destination token, only to encounter 'No quotes available' for the native token and 'Error fetching quotes' for other tokens. A more user-friendly approach could involve defaulting to the regular send flow for non-supported networks (removing the option to select a destination token).

Expected behavior

-

Screenshots/Recordings

Steps to reproduce

Connect to unsupported network (e.g., Polygon, Arbitrum, etc.)
Start send+swap flow
Select native token as an origin token and any other token for the destination
See 'No quotes available' message
Select non-native token as an origin
Select any token as a destination token
'Error fetching quotes' is shown

Error messages or log output

No response

Version

develop branch

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

BZahory commented 3 months ago

This was addressed in a meeting yesterday: https://docs.google.com/document/d/1bfuJ3oRx3KHBtCZnySJjuTJ8r4FVVqDV3Eb-xxYJ4Zs/edit#heading=h.4mo58br3ahpy

tl;dr: this is expected since the API isn't updated yet, but we expect it to be updated by mid-next week. Keeping this issue open until this actually happens

sleepytanya commented 2 months ago

Currently for unsupported networks we allow users to select destination token and then display 'No quotes available' or 'Error fetching quotes' message.

https://github.com/MetaMask/metamask-extension/assets/104780023/f11298b6-363b-4c09-b936-992c567452b7

danjm commented 2 months ago

@BZahory Why not disable the dropdown if the network is unavailable?

BZahory commented 2 months ago

@BZahory Why not disable the dropdown if the network is unavailable?

That's the current behavior. We previously assumed that all swap networks would be supported. Exact swap+send networks are now available here: https://swap.dev-api.cx.metamask.io/featureFlags; I'll make a PR to use these

metamaskbot commented 2 months ago

Missing release label release-12.0.0 on issue. Adding release label release-12.0.0 on issue, as issue is linked to PR #25474 which has this release label.

sleepytanya commented 2 months ago

The issue is present in the latest v12.0.0 build