We need to prioritize the removal of extra MV3 builds from our pipeline. This task involves identifying and removing these builds to streamline our build process.
All the build code currently runs twice: once for MV2 and MV3.
Question is: can we modify the build scripts such that the same script can generate all builds we need (MV2, MV3, Chrome, Firefox)?
Answer: yes. What we need to do is replace all uses of the ENABLE_MV3 environement variable with code that relies on the manifest version. Then, in a few places in the build code, we will need to rely on the browser type instead of whether the build is mv3 or not (e.g. when building the offscreen document and the manifest).
Alternatively (or in addition), we shall evaluate if we can use the event pages on Firefox for Offscreen, as we currently do on Chrome? It's likely the answer is yes.
Out of scope for this issue: ship MV3 in Firefox.
Scenario
No response
Design
No response
Technical Details
No response
Threat Modeling Framework
No response
Acceptance Criteria
No response
Stakeholder review needed before the work gets merged
[x] Engineering (needed in most cases)
[ ] Design
[ ] Product
[ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
Gudahtt
commented
5 months ago
What is this about?
We need to prioritize the removal of extra MV3 builds from our pipeline. This task involves identifying and removing these builds to streamline our build process.
All the build code currently runs twice: once for MV2 and MV3. Question is: can we modify the build scripts such that the same script can generate all builds we need (MV2, MV3, Chrome, Firefox)?
Answer: yes. What we need to do is replace all uses of the
ENABLE_MV3environement variable with code that relies on the manifest version. Then, in a few places in the build code, we will need to rely on the browser type instead of whether the build is mv3 or not (e.g. when building the offscreen document and the manifest).Alternatively (or in addition), we shall evaluate if we can use the event pages on Firefox for Offscreen, as we currently do on Chrome? It's likely the answer is yes.
Out of scope for this issue: ship MV3 in Firefox.
Scenario
No response
Design
No response
Technical Details
No response
Threat Modeling Framework
No response
Acceptance Criteria
No response
Stakeholder review needed before the work gets merged
References
No response