MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.94k stars 4.89k forks source link

CI Optimization Tactics #25234

Open vthomas13 opened 3 months ago

vthomas13 commented 3 months ago

What is this about?

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

References

https://consensys.slack.com/archives/CTQAGKY5V/p1717679382264779

Gudahtt commented 3 months ago

I would recommend refocusing this issue around a single task. The clearest benefit listed here is to stop running CI workflows for non-PR branches.

We can't easily do this from the CircleCI dashboard because we need CI to run on the develop and master branches even when there is no corresponding PR. But we can bail early on branches other than those, if we detect that there is no corresponding PR.

For the "skip CI for certain types of content updates/commit messages" related ideas, that can get quite complex and deserves a separate issue.