MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.72k stars 4.8k forks source link

Re-introduce spinner for blockaid warnings on redesigned confirmations #25323

Closed bschorchit closed 1 month ago

bschorchit commented 1 month ago

What is this about?

While we'll re-visit this to improve the loading UI in the future, we should re-introduce the existing spinner for when blockaid's warning is still loading in the meantime to prevent user confusion when the alert UI is suddenly triggered.

Scenario

https://github.com/MetaMask/metamask-extension/assets/34968356/410502f2-ed5e-42bb-9144-7a554f096bed

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

References

No response

jpuri commented 1 month ago

@bschorchit , @SayaGT : currently spinner appears as in image below:

Image

Can you plz suggest design for re-designed pages.

SayaGT commented 1 month ago

Hey @jpuri you can find the design here Let me know if you have any questions.