MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.65k stars 4.77k forks source link

Uncaught out of memory #25343

Open plasmacorral opened 2 weeks ago

plasmacorral commented 2 weeks ago

Describe the bug

Was testing with a snap account in async mode with the test dapp in Firefox 127.0 on Mac Sonoma 14.5. I have not pinned down reliable steps of what led up to the extension locking up, and unfortunately lost a key 6 minute chunk of recording. In the recording I have available you can see extension is a bit sluggish.

Expected behavior

Extension to handle dapp interations including rejected confirmations.

Screenshots/Recordings

Still

LONG and inclusive Recording of events leading up to out of memory

Statelogs: FirefoxOutOfMemory.json

Steps to reproduce

Unclear at this time

Had 4 HD accounts, 1 Imported account, and 6 SSK created snap accounts Was dapp connected with the imported account to: Pancakeswap.finance on Base ENS on ethmainnet Opensea on ethmainnet Odos.xyz on Arbitrum Test-dapp on Sepolia

Conducted multiple sends with the test dapp, as well as deployed ERC20 and signatures all with async approval on the SSK. Also had some transactions that I rejected.

Error messages or log output

Uncaught out of memory
Uncaught (in promise) out of memory

Version

12.0.0

Build type

None

Browser

Firefox

Operating system

MacOS

Hardware wallet

Other (please elaborate in the "Additional Context" section)

Additional context

Was migration testing with snap account created with SSK 1.1.1 and was recently testing with the test dapp when slowness was observed and extension froze.

Severity

No response

hesterbruikman commented 1 week ago

@plasmacorral how confident are you that this is a regression on v12? Is there a way to confirm that it is?

plasmacorral commented 1 week ago

Until we sort out reproduction steps, not sure I can say one way or the other, unfortunately.