search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.83k stars 4.82k forks source link

[Bug]: When Smart transactions enabled, send+swap transactions sometimes displayed as "Send as" within the Activity tab without explicitly specifying the involved token #25355

Open sleepytanya opened 2 months ago

sleepytanya commented 2 months ago

Describe the bug

When Smart transaction toggle is ON, send+swap transactions sometimes displayed as "Send as" within the Activity tab without explicitly specifying the involved token.

Expected behavior

-

Screenshots/Recordings

Screenshot 2024-06-15 at 15 44 36

https://github.com/MetaMask/metamask-extension/assets/104780023/fd6f0420-f964-47bb-aead-92172c5a0920

Steps to reproduce

  1. Enable Smart Transactions in the Settings->Advanced
  2. Start send+swap transaction (select different destination token)

Error messages or log output

No response

Version

12.0.0

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

dan437 commented 2 months ago

I've removed the regression-RC-12.0.0 label, since we disabled smart transactions for this new Send&Swap feature here: https://github.com/MetaMask/metamask-extension/pull/25422

We will make smart transactions work with Send&Swap in one of the future releases.