[Bug]: When the Approval request is initiated from a dApp, users may encounter varying approval screens

[sleepytanya]

Describe the bug

When the Approval request is initiated from a dApp, users may encounter varying approval screens. Note: one of the Approval screen shows '1 of 2' on the top right corner - is it expected?

Expected behavior

-

Screenshots/Recordings

https://github.com/MetaMask/metamask-extension/assets/104780023/e9539974-a92d-404e-9626-3abf8d941303

Steps to reproduce

1. Connect to a dApp
2. Trigger Approval transaction

Error messages or log output

No errors

Version

12.0.0

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

[hesterbruikman]

@sleepytanya could you try and reproduce and checking the request type in the console. If it shows, perhaps checking with an engineer on the team if needed. Assumption is that the dapp is sending different request types approve vs allowance method.

[digiwand]

might be related https://github.com/MetaMask/metamask-extension/issues/18801

[bschorchit]

Marking this as a release-blocker for v12.0.0 until we investigate more

[bschorchit]

Note: one of the Approval screen shows '1 of 2' on the top right corner - is it expected?

This is expected as it's a 2-page confirmation.

[sleepytanya]

Can't reproduce on the latest build [https://github.com/MetaMask/metamask-extension/commit/eebc4d5b2284024eaeb190cddfa89990f593ca34]

[bschorchit]

We are downgrading severity on this issue as we're no longer able to reproduce this issue. We'll keep it open as we continue trying to reproduce it on our side. We'll raise severity of this again, if needed.