search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.65k stars 4.77k forks source link

[Bug]: Unexpected popup behavior when interacting with dapps #25393

Open sleepytanya opened 2 weeks ago

sleepytanya commented 2 weeks ago

Describe the bug

Popup functionality seems working not as expected.

Scenarios:

  1. Have unapproved transaction

  2. Request to switch network - number on the MM icon will increase +1

  3. Popup appears but you can't see the network request, only the unapproved transaction

  4. If you access the popup manually it will show the unapproved transaction

  5. After unapproved transactions rejected, network request can be seen

  6. If you go to the MM home page and reject unapproved tx from there the network request will be shown in full screen mode

  7. Switch network, do not approve

  8. Go to another dapp

  9. Start transaction

  10. MM icon number will increase +1

  11. Popup appears but shows only network request

  12. If you access the popup manually it will show the unapproved transaction request

  13. After unapproved transactions rejected, network request can be seen

  14. If you go to the MM home page and reject unapproved tx from there the network request will be shown in full screen mode

Related issues:

https://github.com/MetaMask/metamask-extension/issues/25361

https://github.com/MetaMask/metamask-extension/issues/25397

Slack discussion links:

https://consensys.slack.com/archives/C03ETQA9EPK/p1695933147044299

https://consensys.slack.com/archives/C03ETQA9EPK/p1695932531166009

Expected behavior

-

Screenshots/Recordings

https://github.com/MetaMask/metamask-extension/assets/104780023/5bc1388b-f0ff-4843-81fa-386a21ae43a5

https://github.com/MetaMask/metamask-extension/assets/104780023/8759f31f-e53b-4be2-b200-a3c0bf2d3d1b

Screenshot 2024-06-17 at 15 04 58

Steps to reproduce

In the description^^

Error messages or log output

No response

Version

11.16.11

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

hesterbruikman commented 2 weeks ago

@bschorchit it looks like this issue might describes expected behavior around confirmations sequencing that is not obvious from the UI. Knowing the evolution of confirmation designs, can you take a look please and share if you see it likely this issue can be addressed with a UI improvement? cc @sleepytanya

bschorchit commented 1 week ago

I've assigned this to confirmations @hesterbruikman