MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.7k stars 4.79k forks source link

[Bug]: Transaction reverted if Swap is initiated from token detail #25463

Open davibroc opened 4 weeks ago

davibroc commented 4 weeks ago

Describe the bug

If I try click on a token in the wallet and try to initiate a swap, there transaction is reverted with an error missing revert data in call exception; Transaction reverted without a reason string. See video below

Expected behavior

No response

Screenshots/Recordings

https://github.com/MetaMask/metamask-extension/assets/6082863/d23f7a26-347c-44a1-80ec-ab55599d352e

Steps to reproduce

  1. Click on a token in the wallet
  2. Click on Swap
  3. Select any token
  4. Get a quote and try to swap

Notice the error fetching quote and see the details in the console

Error messages or log output

No response

Version

12.0.0

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

davibroc commented 3 weeks ago

@infiniteflower cannot reproduce it with the official RC build, only when I build the app locally. This likely has the same root cause as this https://github.com/MetaMask/metamask-extension/issues/25463 which is rate limiting. I have lowered the severity and remove the release blocker label

dan437 commented 3 weeks ago

Since there is "Error fetching quotes", can the Swaps team have a look first? image