[Bug]: When a user has a Smart transaction in a Pending state and initiates a transaction through a dApp on a different network, the dApp transaction is generated with an empty nonce. Pressing the 'Confirm' button then leads to an endless loading spinner.

sleepytanya commented 4 days ago

Describe the bug

v12.0.0 build [https://github.com/MetaMask/metamask-extension/commit/f5631fba1e83899f3e8d8a1bf2b1fc0de9fb87c6]

When a user has a transaction (STX) in a Pending state and initiates a transaction through a dApp on a different network, the dApp transaction is generated with an empty nonce. Pressing the 'Confirm' button then leads to an endless loading spinner. After reloading the extension, the second transaction's popup becomes accessible, and the transaction is then displayed with the correct nonce.

Expected behavior

-

Screenshots/Recordings

https://github.com/MetaMask/metamask-extension/assets/104780023/a24fda33-25a3-4ad0-b1c0-1dc422065279

Steps to reproduce

Turn on nonce customization in the SEttings->Advanced
Connect to Ethereum
Send STX (set low gas fee so the STX stays in 'Pending' state for awhile)
Connect to dapp (Pancake Swap, Uniswap) to BNB or other network
Start a dapp transaction
Notice that nonce field is empty
Confirm the transaction, see the loading spinner

Error messages or log output

Version

v12.0.0

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

sleepytanya commented 4 days ago

First STX on mainnet from Uniswap, in 'Pending' state
Second transaction on BNB from Pancake Swaps
The popup for the second tx shows empty Activity tab
Second transaction appears on the Activity tab after ~30-45 seconds in 'Unapproved' state

https://github.com/MetaMask/metamask-extension/assets/104780023/6f7613b9-f5b7-4e65-88f8-4c514df2e06f