MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.99k stars 4.91k forks source link

[Bug]: Translation not fully available for Romanian, Norwegian, Italian, Danish, and others #25698

Open anaamolnar opened 3 months ago

anaamolnar commented 3 months ago

Describe the bug

Settings->General, Settings->Advanced, Settings->Permissions not fully translated to other languages.

Expected behavior

I should see the translation in my chosen language for each section of the Settings menu.

Screenshots/Recordings

image

Steps to reproduce

  1. Go to Settings->General
  2. Change language to Italian, Romanian, Norwegian
  3. Some parts of the Settings are not translated from english.

Error messages or log output

No response

Version

12.0.0

Build type

Beta

Browser

Chrome, Firefox

Operating system

Windows, MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

Gudahtt commented 3 months ago

This is expected; those locales are community translations, and they are typically incomplete.

It does seem inappropriate to list them alongside our complete translations though. Maybe we could have these in a separate list, or have a warning somewhere about them being incomplete.

gauthierpetetin commented 3 months ago

Recategorising this from type-bug into type-enhancement

i18nlaurel commented 3 months ago

Thank you for flagging this! I like the idea to delineate the community translations from the professionally-completed translations. If possible, could we also include a link to the forum for translation submissions to encourage more members of our community to contribute?

chloeYue commented 3 months ago

Some missing translations on onboarding screens Screenshot 2024-07-16 at 17 09 16 Screenshot 2024-07-16 at 17 08 28

jvbriones commented 3 months ago

other missing translations on onboarding screens: Screenshot 2024-07-17 at 16 23 01 Screenshot 2024-07-17 at 16 26 14

i18nlaurel commented 3 months ago

Some missing translations on onboarding screens Screenshot 2024-07-16 at 17 09 16 Screenshot 2024-07-16 at 17 08 28

Thank you for flagging these. Because the Italian and Polish translations were submitted by community members, we don't have plans to expand these translations for now - which I recognize is not ideal from a UX standpoint. Ideally we could delineate between the languages that are professionally (and completely - for the most part 😆) translated and the languages that have incomplete translations because they were crowd-sourced (as Mark mentioned above).

Thank you for flagging those untranslated elements @jvbriones! I'll check on these strings and follow up here. As long as they are in the Spanish locale es, the translations should be complete.

--Coming back to this later, I checked on these strings and I do see that translations are populating for both strings. 1. The first marketing consent toggle and 2. the basic functionality string. Can we think of any other reason why these translations would be live in the code but not live in the extension?