MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.81k stars 4.82k forks source link

[Bug]: Notifications - `Error fetching from Contentful after 3 retries: Error: Fetch failed with status: 404` #25748

Closed seaona closed 1 month ago

seaona commented 1 month ago

Describe the bug

Whenever I enable notifications I see the following background error Error fetching from Contentful after 3 retries: Error: Fetch failed with status: 404and it takes several seconds for the loading spinner to disappear (not sure if it's related).

Expected behavior

No error and good performance

Screenshots/Recordings

Screenshot from 2024-07-10 18-04-55

https://github.com/MetaMask/metamask-extension/assets/54408225/6ec3c2c8-2266-4855-b3b8-c3bb75b34566

Steps to reproduce

  1. Onboard
  2. Click Enable notifications
  3. See error in the background/service worker console

Error messages or log output

No response

Version

12.0.0

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

Severity

No response

sleepytanya commented 1 month ago

Different error on 12.1.0, appears every time I turn notifications ON and OFF:

https://github.com/MetaMask/metamask-extension/assets/104780023/638f39b7-0faf-4384-af83-18c902363ac2

Screenshot 2024-07-10 at 18 28 08
Prithpal-Sooriya commented 1 month ago

TY. Jira Ticket created here. Our team will investigate.

Prithpal-Sooriya commented 1 month ago

It may be that this API call to contentful is missing some environment variables on dev, but has been added to our CI pipeline/releases.

We will find a better way to handle this.

Prithpal-Sooriya commented 1 month ago

A PR has been made in core libraries.

We are in the process of getting the extension to use the core libraries, but can backport this into extension.

Prithpal-Sooriya commented 1 month ago

This was backported here: https://github.com/MetaMask/metamask-extension/pull/25979

Prithpal-Sooriya commented 1 month ago

This is fixed in v12.0.0