MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.86k stars 4.84k forks source link

[Bug]: Batch request error smartTransaction:showSmartTransactionStatusPage #25796

Open Pasha8914 opened 2 months ago

Pasha8914 commented 2 months ago

Describe the bug

When sending a batch of transaction requests, an error occurs on the second transaction. However, the transaction is mined successfully.

Expected behavior

When sending a batch of transaction requests, it should be processed without errors, and the transaction hash must be returned

Screenshots/Recordings

https://github.com/user-attachments/assets/83ead1f5-5590-44a7-b021-eb0a3acb9140

Steps to reproduce

  1. Run project
  2. Click Send self-tx
  3. Sign first transaction
  4. Sign second transaction as soon as the signature button is unlocked.

Error messages or log output

Request of type 'smartTransaction:showSmartTransactionStatusPage' already pending for origin chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn. Please wait.

Version

11.16.14

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

forest-diggs-consensys commented 2 months ago

This is fixed in v12, though a transaction hash is only returned once a transaction is finalized. For context, this is to account for the case of dropped/automatically cancelled transactions (ie. if we detect a transaction would revert). This case is handled the same as if a user rejected the first transaction. Following that, the user will be able to confirm the 2nd queued transaction.

Pasha8914 commented 2 months ago

This is fixed in v12, though a transaction hash is only returned once a transaction is finalized. For context, this is to account for the case of dropped/automatically cancelled transactions (ie. if we detect a transaction would revert). This case is handled the same as if a user rejected the first transaction. Following that, the user will be able to confirm the 2nd queued transaction.

when to expect the release of version 12