[Bug]: Accounts missing from dapp connection list and unable to disconnect

[plasmacorral]

Describe the bug

1) Connected Accounts Not Displayed:

• Accounts connected to the dapp are not shown in the list of connected accounts.
• Switching to an unconnected account and connecting it does not update the account list.

2) Disconnect All Accounts:

• Following the prompts to disconnect all accounts does not actually disconnect the test dapp.

3) Connection Reference:

• The "disconnect all accounts" flow references the extension ID instead of the dapp URL, unlike in v12.0.0.
• This issue also affects individual account connections.

Expected behavior

1. When an account is connected to a dapp it should show in the list of connected accounts.
2. When I follow the prompts to disconnect all accounts, then the dapp should be disconnected.
3. The DAPP in question should be shown rather than the extension ID.

Screenshots/Recordings

Recording showing 1 and 2:

recording

Still images for 3) Extension ID showing instead of DAPP URL

Steps to reproduce

Accounts not listed as connected

1. Have multiple accounts in a wallet
2. Connect the test dapp to an account, call it account A
3. Check the dapp connection and confirm the account A is connected, but note that it is not showing any accounts connected
4. Switch active account to something else, call it account B
5. Note the prompt that account B is not connected to the DAPP, and connect to it
6. Check the dapp connection and confirm the account B is connected, but note that it is not showing any accounts connected A or B.

Disconnect all and note that DAPP is still connected

1. From the steps above, hit the CTA to "Connect accounts" and follow the prompts to connect both accounts A and B
2. Hit Next
3. Confirm
4. Open the dapp connection menu
5. Tap Disconnect all accounts
6. Tap `Disconnect to confirm
7. Refresh page on the test dapp
8. tap Eth Accounts and note that both accounts A & B are still connected.

Error messages or log output

No response

Version

12.1.0

Build type

None

Browser

Chrome, Firefox

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

[gantunesr]

From this thread in the accounts channel

This issue has already been merged into develop, we need to validate the fix and cherry-pick it into the release 12.1.0

[plasmacorral]

Cherry pick has QA passed, closing this issue as resolved.

[metamaskbot]

Missing release label release-12.2.0 on issue. Adding release label release-12.2.0 on issue, as issue is linked to PR #25500 which has this release label.