Closed digiwand closed 4 months ago
Marked 3 in the list as done. Did a quick search and did not find other places we could reuse calcTokenAmount.
I think for the remaining two, it is not necessary to utilize calcTokenAmount since they have their own logic using Numeric with hex values. There are also no known issues for these two.
ui/components/ui/token-input/token-input.component.js
ui/components/app/currency-input/currency-input.js
What is this about?
Once https://github.com/MetaMask/metamask-extension/pull/25799 is merged, we can use
calcTokenAmount
in other parts of the application. Applying this consistency may prevent bugs and ensure consistent resultsFiles we can update with this PR:
ui/components/ui/token-input/token-input.component.js
ui/components/app/currency-input/currency-input.js
ui/ducks/send/send.js
~ doneui/pages/confirmations/components/confirm/info/typed-sign/permit-simulation/permit-simulation.tsx
~ doneui/pages/confirmations/components/confirm/row/dataTree.tsx
~ donePotentially other files could be included.
Scenario
No response
Design
No response
Technical Details
No response
Threat Modeling Framework
No response
Acceptance Criteria
No response
Stakeholder review needed before the work gets merged
References
No response