MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.84k stars 4.83k forks source link

[Bug]: many pop-ups show up unexpectedly when submitting transaction with MM extension into Cypress framework #26060

Open lidiia-kondratiuk opened 1 month ago

lidiia-kondratiuk commented 1 month ago

Describe the bug

During transaction confirmations in Cypress with the MetaMask wallet extension, we encounter a problem where several strange pop-ups appear simultaneously, which shouldn't be happening. It blocks us from completing all tests that include the transaction submission step. As a result, all such tests like delegation votes, publishing proposals on-chain, and voting on proposals are failing.

We are using this meta mask synpress: "name": "metamask.synpresstests", "version": "1.0.0", "license": "ISC", "dependencies": { "@synthetixio/synpress": "^3.7.3", "node-fetch": "^2.7.0"

Expected behavior

Once the transaction is completed with MM extension into Cypress, we should not see any additional pop-ups that can not be closed.

Screenshots/Recordings

image (3)

Steps to reproduce

Preconditions: you need to have automated test via Cypress framework and integrated metaMask extension into.

  1. Open your automated test into Visual Studio.
  2. Force executing this test with the transaction.
  3. See how unexpected many pop-up from MetaMask extension appear once the transaction is completed.

Error messages or log output

Three pop-ups that can not be closed automatically in Cypress framework when executing transaction submission.

Detection stage

In production (default)

Version

11.16.14

Build type

None

Browser

Chrome

Operating system

Windows, MacOS

Hardware wallet

No response

Additional context

We are using Cypress framework with integred MM extension 11.16.14

Severity

It`s a blocker issue for automated tests via Cypress frameworks and MM extension

seaona commented 1 month ago

hey @lidiia-kondratiuk, thank you for reporting this! Could you let us know,

Thank you in advance!

lidiia-kondratiuk commented 1 month ago

Hey Seaona, My team is using this Chrome 126.0.6478.183 version. This issue started happening 1 month ago from 25th June. We have been trying to fix this ourselves but have had no results. Good questions about the previous version. Let us to try reinstalling the previous version to see if it will work. Also, Im adding the error form console that causes the issue with pop-ups: CypressError:cy.task('confirmMetamaskSignatureRequest')` failed with the following error:> page.waitForEvent: Timeout 30000ms exceeded while waiting for event "close" =========================== logs =========================== waiting for event "close"

Many thanks for considering my request!

On Thu, Jul 25, 2024 at 6:39 PM seaona @.***> wrote:

hey @lidiia-kondratiuk https://github.com/lidiia-kondratiuk, thank you for reporting this! Could you let us know,

  • which is the Chrome version you are using?
  • when did this behaviour start happening?
  • I see you reported MM version 11.16.14, is it working on MM previous versions?

Thank you in advance!

— Reply to this email directly, view it on GitHub https://github.com/MetaMask/metamask-extension/issues/26060#issuecomment-2250718927, or unsubscribe https://github.com/notifications/unsubscribe-auth/BFN5LBIUA6SLNJXXIMVPTRDZOEL2VAVCNFSM6AAAAABLK7EVRKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJQG4YTQOJSG4 . You are receiving this because you were mentioned.Message ID: @.***>