Stop caching non-persisted controller state to reduce disk and potentially memory usage

[desi]

What is this about?

We currently cache a lot of non-persisted controller state as persisted state. This state was meant only to be used for service worker restarts, but that doesn't happen right now due to our service worker keepalive strategy. We should stop caching this non-persisted state, which would reduce disk usage.

It's possible that reducing the size of persisted state would also reduce memory usage. I am not certain if this would hold true once we clear getMostRecentPersistedState, but it might, and it's a nice disk usage optimization regardless.

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

• [X] Engineering (needed in most cases)
• [ ] Design
• [ ] Product
• [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
• [ ] Security
• [ ] Legal
• [ ] Marketing
• [ ] Management (please specify)
• [ ] Other (please specify)

References

No response

[Gudahtt]

I have recategorized this as Sev2 because the impact isn't significant enough on its own to meet the criteria for Sev1. This is related to a Sev1 issue about reports of extreme slowness and crashes, but we don't have any reason to suspect that this specific bug is a major contributor to that problem. It's likely a small contributor.