MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.84k stars 4.83k forks source link

[Bug]: Errors in the console when enabling notifications for an account #26068

Open sleepytanya opened 1 month ago

sleepytanya commented 1 month ago

Describe the bug

Every time when user enables notifications for the account there are errors in the console.

Develop:

https://github.com/user-attachments/assets/70879d42-7e54-4b0e-95d6-70e544897ece

Screenshot 2024-07-23 at 15 51 38

Latest v12.0.0 build and beta - only 'Uncaught' errors:

https://github.com/user-attachments/assets/9bb0b32c-f2e4-4a89-84de-6b9c978e19e8

https://github.com/user-attachments/assets/cd2c03e4-3b8e-4c0d-8e05-98f13a2fc041

Expected behavior

-

Screenshots/Recordings

No response

Steps to reproduce

  1. Go to Notifications
  2. Disable / Enable notification for account

Error messages or log output

No response

Detection stage

On the development branch

Version

12.0.0

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

Prithpal-Sooriya commented 1 month ago

Related: https://github.com/MetaMask/metamask-extension/issues/25750

The recent changes have made push notifications optional (so still creates notifications, but will silently fail push notifications). What we see here are some logs to inform us that push notifications have failed.

We want these errors to be visible in sentry. Maybe we can change from error logs to warning logs.

We can mark this as low severity and resolve in a future version (12.1)

sleepytanya commented 4 weeks ago

Prod v12.1.0

Every time user disables notifications for the selected account there is an error:

Screenshot 2024-08-09 at 17 22 39

https://github.com/user-attachments/assets/a187094a-6c7d-4bbd-b38e-ab317d0f7d13

Prithpal-Sooriya commented 4 weeks ago

Noted. These error logs are valid (we may make these silent in future versions).

Our team will investigate.

There is a known bug on push notifications with our API.

This impact is on push notifications. It will not impact showing notifications, or modifying settings.