Closed seaona closed 1 month ago
Hey @seaona : I found that request has an issue EIP712Domain is not defined
. Thus the JS code is throwing error in DAPP itself and is never submitted to MM - thus there is no response. Fixing this fixes the issue.
hey Jyoti, could it be that it didn't copy correctly the request? I'm able to reproduce the issue, and the signature is correct
https://github.com/user-attachments/assets/83c35b01-b959-4161-aa90-97c8afcc2fd0
As discussed in Slack, we think to repro without error above, we need to either: a) fetch the latest updates from test-dapp before applying repro steps b) add the EIP712Domain value:
[
{ name: 'name', type: 'string' },
{ name: 'version', type: 'string' },
{ name: 'chainId', type: 'uint256' },
{ name: 'verifyingContract', type: 'address' },
],
I added console time logs to various parts of the rendering. My suspicion is this is related to the DataTree component. The second screenshot uses the same logs as the first, except I added
console.log('rendering DataTree');
console.time('log');
I meant to add
console.log('rendering DataTree');
console.timeLog('log');
but this actually panned out well in the console with it's duplicated outputs.
I also tried to remove the ScrollToBottom component and this did not make a noticeable difference in performance.
cc: @jpuri
Describe the bug
There is a huge performance degradation when triggering long signature messages with the MM version 12.0.0. The wallet get's unresponsive, and it's hard to scroll or even accept/reject the signature. [New] Observations:
Expected behavior
No response
Screenshots/Recordings
https://github.com/user-attachments/assets/d8893068-2f96-4e8f-82ef-079c8f966984
Steps to reproduce
Shorter signature
https://github.com/user-attachments/assets/0acfad1f-7872-434a-ac1b-14f218629670
Error messages or log output
No response
Detection stage
In beta
Version
12.0.0 beta build
Build type
None
Browser
Chrome
Operating system
Linux
Hardware wallet
No response
Additional context
No response
Severity
No response