MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.83k stars 4.83k forks source link

Adapt to EIP-1193 SafeEventEmitterProvider changes #26288

Open desi opened 1 month ago

desi commented 1 month ago

What is this about?

After SafeEventEmitterProvider is updated to support EIP-1193 and a new version of @metamask/eth-json-rpc-provider is released, we should adapt to the changes:

At the high level, there's a one instance of using sendAsync in metamask-controller.js and one place in provider.js (test/stub). And couple of places in web3js.js (test/e2e/send-eth-with-private-key-test).

These changes should then be shipped under a new major version as they will be breaking.

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

Stakeholder review needed before the work gets merged

References

No response

desi commented 1 month ago

@kanthesha please fill in the details for this