Calling sendAsync will be deprecated; we should use request instead.
We'll want to also update the tests.
We'll want to add @metamask/eth-json-rpc-provider as a dev dependency and remove @metamask/eth-query.
At the high level, there's a one instance of using sendAsync in metamask-controller.js and one place in provider.js (test/stub). And couple of places in web3js.js (test/e2e/send-eth-with-private-key-test).
These changes should then be shipped under a new major version as they will be breaking.
Scenario
No response
Design
No response
Technical Details
No response
Threat Modeling Framework
No response
Acceptance Criteria
All the sendAsync method of provider have been replaced with request method of provider
@metamask/eth-query removed from dependency, instead @metamask/eth-json-rpc-provider added as a dev dependency.
All the related tests have been updated
Stakeholder review needed before the work gets merged
[X] Engineering (needed in most cases)
[ ] Design
[ ] Product
[ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
What is this about?
After SafeEventEmitterProvider is updated to support EIP-1193 and a new version of
@metamask/eth-json-rpc-provider
is released, we should adapt to the changes:@metamask/eth-json-rpc-provider
as a dev dependency and remove@metamask/eth-query
.At the high level, there's a one instance of using sendAsync in metamask-controller.js and one place in provider.js (test/stub). And couple of places in web3js.js (test/e2e/send-eth-with-private-key-test).
These changes should then be shipped under a new major version as they will be breaking.
Scenario
No response
Design
No response
Technical Details
No response
Threat Modeling Framework
No response
Acceptance Criteria
sendAsync
method of provider have been replaced withrequest
method of provider@metamask/eth-query
removed from dependency, instead@metamask/eth-json-rpc-provider
added as a dev dependency.Stakeholder review needed before the work gets merged
References
No response