MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.83k stars 4.83k forks source link

[TASK] RCA on Outstream on 'end' callback, in setupControllerConnection of MM controller, is not called on UI close #26002 #26372

Open benjisclowder opened 1 month ago

benjisclowder commented 1 month ago

What is this about?

Hi, Extension team. We need your help in performing a root-cause analysis of this bug as part of our MetaMask Quality Initiative.

Data gathered and investigation results need to be added as a reply to this comment. Please try to answer all questions for best results.

If you are encountering any permission issues, please reach out to me or @gauthierpetetin.

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

References

No response

sunobun commented 1 month ago

Root analysis of this bug as a part of our exodus Quality initiatives

On Mon, 12 Aug 2024 at 17:12, Marina Boboc @.***> wrote:

What is this about?

Hi, Extension team. We need your help in performing a root-cause analysis of this bug https://github.com/MetaMask/metamask-extension/issues/26002 as part of our MetaMask Quality Initiative https://www.notion.so/metamask-consensys/Teams-perform-RCA-for-Sev0-Sev1-Bugs-a80fc81e06d646f389f11e4c171e2ffe?pvs=4 .

Data gathered and investigation results need to be added as a reply to this comment https://github.com/MetaMask/metamask-extension/issues/26002#issuecomment-2284338391. Please try to fill out as many of the fields as possible for better results.

If you are encountering any permission issues, please reach out to me or @gauthierpetetin https://github.com/gauthierpetetin. Scenario

No response Design

No response Technical Details

No response Threat Modeling Framework

No response Acceptance Criteria

No response Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response

— Reply to this email directly, view it on GitHub https://github.com/MetaMask/metamask-extension/issues/26372, or unsubscribe https://github.com/notifications/unsubscribe-auth/BHUP2VMNFDUOBYFFQWN364DZRDNGNAVCNFSM6AAAAABMMPVE3SVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ3DCNBQGIZDSNA . You are receiving this because you are subscribed to this thread.Message ID: @.***>