Remove `showTokenAutodetectModalOnUpgrade` from `AppMetadataController`

[Gudahtt]

What is this about?

The property showTokenAutodetectModalOnUpgrade was mistakenly added to the AppMetadataController in #24281. This controller is intended to track metadata about the wallet to assist in diagnosing state corruption bugs and migration failures. This flag about the token autodetect modal does not belong there.

The AppStateController is where we typically keep track of whether each modal has been seen already or not. We should migrate this flag to that controller instead.

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

• The showTokenAutodetectModalOnUpgrade property has been removed from AppMetadataController
• A migration has been added to remove this property from the AppMetadataController state for existing users
• The token autodetect modal state is tracked in some other way (e.g. using the AppStateController).

Stakeholder review needed before the work gets merged

• [X] Engineering (needed in most cases)
• [ ] Design
• [ ] Product
• [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
• [ ] Security
• [ ] Legal
• [ ] Marketing
• [ ] Management (please specify)
• [ ] Other (please specify)

References

No response

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.