search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
12.08k stars 4.94k forks source link

[Bug]: Lack of origin display on wallet_addEthereumChain #26656

Open digiwand opened 3 months ago

digiwand commented 3 months ago

Describe the bug

Fix https://github.com/MetaMask/MetaMask-planning/issues/3471

todo add details to address fix

Expected behavior

No response

Screenshots/Recordings

No response

Steps to reproduce

  1. Open https://pkeshkamat.github.io/poc15 in a browser with the MetaMask extension installed.
  2. Within 5 seconds, switch to another tab, for example, https://www.gnosis.io/.
  3. The addEthereumChain request will appear as though it came from gnosis.io

Error messages or log output

No response

Detection stage

In production (default)

Version

12.0.5

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

github-actions[bot] commented 1 week ago

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

hjetpoluru commented 20 hours ago

I tested this scenario against the latest 12.7.2 in chrome browser and unable to reproduce the issue. @digiwand, could you please confirm and mark the status accordingly.