search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.97k stars 4.9k forks source link

Fix "Test Snap Installed can tell if a snap is installed ..." flaky tests #26804

Open seaona opened 1 month ago

seaona commented 1 month ago

https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/97960/workflows/5ec17fc7-d3a6-4109-944b-6be43d69ca93/jobs/3646369/tests

chloeYue commented 3 weeks ago

This test is still flaky: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/102400/workflows/2aff7ad3-f1ba-4e54-9a3c-2d5cc2f635af/jobs/3815968

bowensanders commented 2 weeks ago

This particlar flake as shown in the CI example above appears to be due to not having enough of a delay to wait for the browser to scroll an element in to view. Adding 500 more ms of delay should work.

see #27521

seaona commented 2 weeks ago

Same as https://github.com/MetaMask/metamask-extension/issues/27576. This fix is blocked by Snap team releasing a new version of the test snap dapp. I fixed the issue on the dapp level, but the new version needs to be released and updated in the tests by the snaps team

https://github.com/MetaMask/snaps/pull/2782

seaona commented 6 days ago

I re-open this issue open, as the root cause of the issue will be fixed once we have the new version of the test snap: See context here:

https://github.com/MetaMask/snaps/pull/2782