Open sleepytanya opened 2 months ago
hey @sleepytanya , same here , not able to reproduce on the latest build. you can find it here
https://github.com/user-attachments/assets/afc48aaf-46a0-4a35-83b0-b1d6aa6223ef
Although I can see quotes fetched after switching endpoints, it seems to require a higher minimum amount depending on the endpoint. Something to look deeper at.
https://github.com/user-attachments/assets/9c448fe0-832d-47c4-957d-2a12ea238b70
I also see quotes for lower amounts are not fetched when using custom RPC URL. Here I use https://polygon.llamarpc.com:
https://github.com/user-attachments/assets/a1250fa9-1327-4b0d-b6a0-02f586a826b2
Sometimes I see quotes not fetched for different tokens on custom RPC but it appears intermittent.
https://github.com/user-attachments/assets/7c94ebbf-6845-41f8-8b47-b6f53f2f4d61
I do not have exact repro steps but I encountered this error 3 times (different installs) when doing swaps from within the wallet for random tokens using custom RPC - TypeError#4: Cannot read properties of undefined (reading 'trade')
I continue to see the error from the message above, still can't tell steps but it seems like it happens while doing swaps. Sometimes 'Networks switched to' toast appears randomly, disappears by itself:
https://github.com/user-attachments/assets/aed3bb6e-d333-4aa3-9f56-e68ad9db14d3
Quotes are not fetched on alternative RPC for bigger amounts as well (https://binance.llamarpc.com):
https://github.com/user-attachments/assets/1ab08bce-93de-47e4-ba5f-502b9ce67313
Describe the bug
When using a custom RPC URL, there seems to be an issue with swaps not being fetched, and the destination token amount does not automatically update upon changing the input amount
Expected behavior
-
Screenshots/Recordings
https://github.com/user-attachments/assets/ab53545f-14d7-4781-9462-ef4f8d283588
Steps to reproduce
Error messages or log output
No response
Detection stage
On the development branch
Version
12.0.5
Build type
Other (please specify exactly where you obtained this build in "Additional Context" section)
Browser
Chrome
Operating system
MacOS
Hardware wallet
No response
Additional context
Build https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/97568/workflows/28d6cb81-d0e8-410f-ae41-7f8b6cc5c5a9/jobs/3631842/artifacts
Severity
No response