MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.87k stars 4.85k forks source link

[Bug]: Unable to add or sign Trezor account in v12.1.1 #26875

Closed plasmacorral closed 2 weeks ago

plasmacorral commented 2 weeks ago

Describe the bug

Was working on a migration test from 12.1.1 to RC 12.2.0 and noticed that I was unable to add a Trezor account. If I add a Trezor account in a version prior to 12.1.1 I can add the Trezor address, but after migration to v12.2.0 RC 8fa9cc090c2804d0dd5e3448e9d1b25eb958833e I am not able to sign, send, or add more Trezor accounts.

Confirmed that 12.0.6 and 12.1.0 do not have this issue, but 12.1.1 and 12.2.0 are impacted.

This was observed with a Trezor Model T running firmware 2.8.1 on a Mac running Sonoma 14.6.1.

Expected behavior

When using a Trezor address a pop-up window is opened and can communicate with Trezor.

Also, should not show a Ledger Live related error in yellow text while trying to add Trezor.

Screenshots/Recordings

12.1.1: Not able to add the device (or sign if address was present from migration from MM <12.1.1) Recording

12.1.0: Able to send/sign in Chrome Recording

Steps to reproduce

  1. Configure a wallet and get to wallet view
  2. Tap the account
  3. Tap Add account or Hardware wallet
  4. Tap `Add hardware wallet'
  5. Tap Trezor
  6. Note pop-up opens, but green spinner

Error messages or log output

{name: 'Error', message: 'Error: Iframe timeout', stack: 'Error: Error: Iframe timeout\n  at I.i (chrome-exte…anaaeohfgaadkdjecdcmbdigiagi/common-0.js:1:527723', code: undefined, rpc: undefined}
code

Also

 Failed to execute `postMessage` on `Window:  Invalid target origin `unknown` in a call to `postMessage`

Detection stage

In production (default)

Version

12.1.1

Build type

None

Browser

Chrome, Firefox

Operating system

MacOS

Hardware wallet

Trezor

Additional context

No response

Severity

Cannot seem to find a work around to be able to sign or add new accounts to MetaMask.

Gudahtt commented 2 weeks ago

I am able to reproduce this locally as well. It works on v12.1.0, fails on v12.1.1.