[Bug]: Issues with contract interactions alerts

[bschorchit]

Describe the bug

There are a few incorrect behaviors of the new alert system. More detail will be added here.

1. Misleading copy for review alerts modal (claiming potential fund loss even when no risk of fund loss) - video below.
2. Existing modal for the generic alert - screenshot below

Expected behavior

1. Expected UI to be added here
2. No modal should exist for the generic banner alert

Screenshots/Recordings

1. Misleading copy for review alerts modal:

https://github.com/user-attachments/assets/00d759ec-1fde-4f46-8534-6719f5264374

2. Existing modal for the generic alert

Steps to reproduce

Case 1

1. Go to test dapp
2. Don't have funds
3. Trigger malicious mint erc20 on Sepolia
4. Click on Review alerts

Case 2

1. Go to test dapp
2. Trigger malicious contract interaction on Ethereum
3. Click on Review alerts

Error messages or log output

No response

Detection stage

During release testing

Version

12.3

Build type

None

Browser

Brave

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

[seaona]

hi there @bschorchit is the alert system supposed to be in 12.3.0? I'm not able to see it in the RC build from the branch :thinking:

[bschorchit]

Hey @seaona, it is :) but only for signatures and for contract interactions transactions (the general confirmation, not the custom confirmations we have for specific methods) for new installs or users that go to Settings > Experimental > Improved transaction requests. Update: what I said above for transactions is not happening, although the toggle is present. I've opened an issue for it here: https://github.com/MetaMask/metamask-extension/issues/27139

[seaona]

thank you @bschorchit I wanted to try it out, and was getting really confused on why it didn't appear

[benjisclowder]

Fixed by #27354.