Open davibroc opened 1 week ago
I got emergency someone in the hospital. I'll shut up later on today or maybe in the morning Mother's in the hospital, so I gotta be with her. Sorry about that
On Mon, Sep 23, 2024, 3:41 AM Davide Brocchetto @.***> wrote:
Describe the bug
When adding a new network a dialog showing some warnings with the Got it button briefly appears and then vanish withou the user click on the Got it button. See video below Expected behavior
Not sure if the dialog should be there or not but if it should the user should be allowed to read it and click on the Got it button Screenshots/Recordings
https://github.com/user-attachments/assets/df984ad0-d063-4241-8491-270cffb12d5d Steps to reproduce
- Go to Manage Extension
- Reset the Extension
- Try to add a new popular network
- Notice that the modal with the Got it button briefly appears
Error messages or log output
No response Detection stage
During release testing Version
develop Build type
None Browser
Chrome Operating system
MacOS Hardware wallet
No response Additional context
No response Severity
No response
— Reply to this email directly, view it on GitHub https://github.com/MetaMask/metamask-extension/issues/27322, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6CNSQD4CHV7DTZUUBPG5FLZX7A3TAVCNFSM6AAAAABOVOZ57CVHI2DSMVQWIX3LMV43ASLTON2WKOZSGU2DCOBSGIZDCNA . You are receiving this because you are subscribed to this thread.Message ID: @.***>
This is an existing issue that I don't think should strictly be a release blocker (https://github.com/MetaMask/metamask-extension/issues/27099)
Do you know what commit / branch this reproduced on? I know it says 12.6 but I don't see a branch created for it. On the latest develop e2f5602d2a71f749eb40dd0cf1fcc246decce637 I haven't been able to reproduce yet. It's waiting for me to click the button.
Also note that by design it dismisses if you click outside the modal.
https://github.com/user-attachments/assets/09950f39-775b-46b6-bb0c-f893ecf14532
@darkwing @bergeron I can reproduce using develop on commit 18d70ab0
. While this issue might existed before and it was fixed, I can confirm that it’s there again and it’s related to the recent changes. I am sure because I wrote a test automation for swap in switch to Optimism network and I could change the network and in my script I had a step to click on the Got it
button and it worked. But after your changes were merged I had to remove the step to click on the Got it
button as a temporary solution as might script wouldn’t fail as the dialog would vanish right away.
Before (in this case my script was click on Got it
https://github.com/user-attachments/assets/0b1c96ca-08e6-48cb-b9ff-57ae72dda60d
After (in this case the dialog would vanish so I am not longer be able to click on Got it
anymore
https://github.com/user-attachments/assets/f893dc92-7be4-4a9c-9ea6-ca3650038499
If anyone need the script to reproduce it let me know
Describe the bug
When adding a new network a dialog showing some warnings with the
Got it
button briefly appears and then vanish withou the user click on theGot it
button. See video belowExpected behavior
Not sure if the dialog should be there or not but if it should the user should be allowed to read it and click on the
Got it
buttonScreenshots/Recordings
https://github.com/user-attachments/assets/df984ad0-d063-4241-8491-270cffb12d5d
Steps to reproduce
Got it
button briefly appearsError messages or log output
No response
Detection stage
During release testing
Version
develop
Build type
None
Browser
Chrome
Operating system
MacOS
Hardware wallet
No response
Additional context
No response
Severity
No response