search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.93k stars 4.88k forks source link

Fix "Import flow @no-mmi Import wallet using Secret Recov..." flaky tests #27336

Open hjetpoluru opened 1 week ago

hjetpoluru commented 1 week ago

https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/101671/workflows/7916cc8f-082c-4486-8cc0-36802704df43/jobs/3785883/tests

Build - Regular Browser - Chrome Test Scenario - Import flow @no-mmi Import wallet using Secret Recovery Phrase Test Path - /test/e2e/tests/account/import-flow.spec.js

TimeoutError: Waiting for element to be located By(css selector, [data-testid="account-list-menu-details"])
Wait timed out after 10023ms
  (Ran on CircleCI Node 17 of 20, Job test-e2e-chrome)
    at /home/circleci/project/node_modules/selenium-webdriver/lib/webdriver.js:929:17
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

image

chloeYue commented 6 days ago

Test still flaky. CI failure: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/102428/workflows/43303c30-7f7a-4a51-a61c-527cf010f872/jobs/3816802

seaona commented 3 hours ago

@chloeYue do you think we can close this ticket now? The PR which fixed this and other cases with the same root cause has now been merged. See below:

https://github.com/MetaMask/metamask-extension/commit/7a5e4d6b88897eb914780fdd15157fc0d9b6f0c5