[Bug]: ZKSync Asset Link Broken

martahj commented 1 month ago

Describe the bug

When on the ZKSync network, using the default block explorer when enabling the network, the "View asset in explorer" link takes users to an "Oops, we can't find anything" page. This is because the link goes to https://explorer.zksync.io/token/[address] (example) but the correct link for that block explorer is https://explorer.zksync.io/address/[address] (example)

Expected behavior

Be taken to a page on the blockexplorer with the token info.

Screenshots/Recordings

https://github.com/user-attachments/assets/7973e909-30d6-48b4-812f-7af46b9a14c2

Steps to reproduce

Add ZKSync by selecting it from the default list in the "Add Network" panel
Add or import an ERC-20 token
Click on the token in your asset list
Click on "View Asset in Explorer" in the "3 dots" menu on the asset detail screen
Notice that you are taken to a no-op page

Error messages or log output

No response

Detection stage

In production (default)

Version

12.2.4

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

gauthierpetetin commented 1 month ago

Notes from triage session:

It seems the root cause is that the zksync explorer is not compatible with EIP 3091, which means the bug is not on our side. Removing the type-bug label to reflect that.
Suggested next step:
- find a zksync explorer that's compatible with EIP 3091
- open a bug on https://explorer.zksync.io 's repo

cc @MetaMask/metamask-assets for visibility

benjisclowder commented 1 month ago

Hi @desi , considering Gauthier's point above, we are removing the type-bug label as this is not a bug on our side (MetaMask).

MetaMask / metamask-extension