search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.97k stars 4.9k forks source link

[Bug]: Watch Account - Watching a big whale account with lots of tokens affects wallet performance making it slower and laggish #27500

Open seaona opened 2 weeks ago

seaona commented 2 weeks ago

Describe the bug

Adding a big whale account with the new Watch Account functionality can cause a performance impact to the wallet, when importing all its tokens.

Expected behavior

No response

Screenshots/Recordings

https://github.com/user-attachments/assets/f601b03f-c877-4029-ba3e-05d88495fccb

Steps to reproduce

  1. Select Mainnet
  2. Go to Experimental Settings
  3. Enable Watch Account
  4. Click Account menu
  5. Click Add
  6. Click Watch Account
  7. Add vitalik.eth
  8. Import all tokens and NFTs
  9. See wallet is slower / laggish -- note this might depend on your computer performance too, so you can add a couple of more big whale accounts to experience it if needed

Error messages or log output

No response

Detection stage

During release testing

Version

12.4.0

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

Severity

No response

seaona commented 2 weeks ago

:information_source: I added this as release blocker, since it's likely that users add multiple whale accounts and encounter the performance degradation. Feel free to re-assess if needed. Not sure how the fix should be: is it realistic that we can improve performance? or is it more realistic to limit the number of watched accounts you can add (based on the owned tokens or something similar?)

seaona commented 2 weeks ago

removing the release-blocker label as it will be launched in flask