MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
12.08k stars 4.94k forks source link

Fix flaky "Test Snap Cronjob can trigger a cronjob to open a dialog every minute" flaky test #27576

Closed seaona closed 1 month ago

seaona commented 2 months ago

What is this about?

https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/102974/workflows/b7dff65d-661f-4bb6-a8d5-d32ff34be250/jobs/3837339/tests

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

References

No response

seaona commented 2 months ago

This fix is blocked by Snap team releasing a new version of the test snap dapp. I fixed the issue on the dapp level, but the new version needs to be released and updated in the tests by the snaps team

https://github.com/MetaMask/snaps/pull/2782

seaona commented 1 month ago

The PR has been merged