Closed lukaw3d closed 1 month ago
For reference, if url and domain is message are swapped:
- `metamask.github.io wants you to sign in with your Ethereum account:
+ `helloworld.io wants you to sign in with your Ethereum account:
- URI: https://helloworld.io
+ URI: https://metamask.github.io
12.2.4 displayed:
If you still want the bad domain to also be visible on this screen then https://github.com/MetaMask/metamask-extension/pull/27754 isn't sufficient
Describe the bug
URI field
https://helloworld.io
in SIWE message is not displayedExpected behavior
See
https://helloworld.io
somewhereScreenshots/Recordings
Steps to reproduce
Open https://metamask.github.io/test-dapp/ and run this in console:
URL field displays
metamask.github.io
Error messages or log output
No response
Detection stage
In production (default)
Version
12.2.4
Build type
None
Browser
Chrome
Operating system
Linux
Hardware wallet
No response
Additional context
https://github.com/MetaMask/metamask-extension/blob/537b3fe32b8af594359e6c9180b9889288173e99/ui/pages/confirmations/components/confirm/info/personal-sign/siwe-sign/siwe-sign.tsx#L46-L48
doesn't use
siweMessage.uri
cc @jpuri
Severity
No response