MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.94k stars 4.88k forks source link

[Bug]: ERC20 Approve - Editing the spending cap value with more decimals than expected, leaves popup loading indefinetly #27618

Open seaona opened 2 days ago

seaona commented 2 days ago

Describe the bug

With the new Approve ERC20 redesign screen, when I edit the Spending cap and I pass a value with more decimals than the token supports, the edit popup stays loading indefinitely

Expected behavior

Same as we had before? Despite adding more decimals, those were not added on the input value

Screenshots/Recordings

https://github.com/user-attachments/assets/abf62cc5-3bea-45f5-a305-357700664ad4

Steps to reproduce

  1. Deploy an ERC20 token
  2. Trigger Approve
  3. Edit Approve amount by passing more decimals than the token supports
  4. See loading popup

Error messages or log output

No response

Detection stage

During release testing

Version

12.6.0

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

Severity

No response

seaona commented 2 days ago

I've marked it as release blocker, because I assume we want it fixed before releasing. However, it's not a sev1 because the issue is non-blocking and you can always close the tx and re-triggered it again cc @bschorchit