MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.95k stars 4.89k forks source link

[Bug]: Changing Swap source token frequently causes extension to crash #27625

Open martahj opened 1 week ago

martahj commented 1 week ago

Describe the bug

Changing the swap source token frequently causes the extension to crash.

Expected behavior

I expected the extension not to crash and to continue to get quotes

Screenshots/Recordings

Video of issue https://github.com/user-attachments/assets/8445e684-a47f-46c0-b12a-1a363c92f561

Error in console

Screenshot 2024-10-04 at 8 35 03 AM

Steps to reproduce

  1. Go to Swaps page
  2. Select a source token + amount and a destination token
  3. Keep changing the source token until the extension crashes

Error messages or log output

No response

Detection stage

In production (default)

Version

12.2.4

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

Unik0rnMaggie commented 2 days ago

Present in v12.5.0 RC

https://github.com/user-attachments/assets/df435a03-2227-455c-b050-6b9287f1e96e

martahj commented 23 hours ago

I think this was fixed in https://github.com/MetaMask/metamask-extension/pull/27708 - @jclancy93 could you cherry-pick that fix into the v12.5.0 RC?