search

MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.97k stars 4.9k forks source link

Fix "Test Survey should show 2 surveys, and then none" flaky tests #27670

Open hjetpoluru opened 2 weeks ago

hjetpoluru commented 2 weeks ago

https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/103756/workflows/32e90a95-92e9-4497-a732-a8dfdf93e122/jobs/3867566/tests

Build - Webpack Browser - Chrome Test scenario - Test Survey should show 2 surveys, and then none Test Path - /test/e2e/tests/survey/survey.spec.js

TimeoutError: Waiting for element to be located By(css selector, [data-testid="survey-toast"])
Wait timed out after 10152ms
  (Ran on CircleCI Node 9 of 20, Job test-e2e-chrome-webpack)
    at /home/circleci/project/node_modules/selenium-webdriver/lib/webdriver.js:929:17
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

image

hesterbruikman commented 3 hours ago

Could this be the result of having two survey toasts? @HowardBraham @jonybur? https://github.com/MetaMask/metamask-extension/pull/27735 (Slack thread)