jpuri
commented
1 day ago Hey @sleepytanya , I also faced this issue at some point, but I am not able to replicate this in latest code:
https://github.com/user-attachments/assets/94ed2b94-aca9-4bb8-9195-edbda4c608be
sleepytanya
Describe the bug
Navigation between two pending malicious transactions breaks MetaMask with errors:
Cannot read properties of undefined (reading 'length')and
Message: Should have a queue. This is likely a bug in ReactAt the moment, functionalities like
Malicious ERC20 Approval (BUSD)andMalicious Set Approval for Allare not operating as anticipated in both the develop branch and the RC 12.5.0 version on Base and BNB networks.https://github.com/MetaMask/metamask-extension/issues/27909
https://github.com/MetaMask/metamask-extension/issues/27905
If a user initiates two consecutive transactions where the latter is a Malicious Set Approval for All, attempting to navigate between these transactions in the popup triggers an error. However, in the Expanded view, these transactions appear as unapproved and can be successfully processed or cancelled.
Expected behavior
No errors
Screenshots/Recordings
https://github.com/user-attachments/assets/e061546a-3d62-4108-a2ba-09c90c8b1751
https://github.com/user-attachments/assets/c2920982-a210-4bf1-8079-8377a4467af8
Steps to reproduce
Malicious Set Approval for AllAlternatively, triggerMalicious Set Approval for Allfirst and then any button from PPOM section - this will produce another type of error.Error messages or log output
No response
Detection stage
On the development branch
Version
12.4.1
Build type
None
Browser
Chrome
Operating system
MacOS
Hardware wallet
No response
Additional context
No response
Severity
No response