Fix "Confirmation Redesign ERC721 Approve Component Submit an Approve transaction @no-mmi Sends a type 2 transaction (EIP1559)"

[seaona]

What is this about?

https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/106162/workflows/f5e12fd8-1e8e-42db-a142-704f62e18a8f/jobs/3965001/tests

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

• [ ] Engineering (needed in most cases)
• [ ] Design
• [ ] Product
• [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
• [ ] Security
• [ ] Legal
• [ ] Marketing
• [ ] Management (please specify)
• [ ] Other (please specify)

References

No response

[hjetpoluru]

Here is the fix for this flaky test - https://github.com/MetaMask/metamask-extension/pull/27928

[hjetpoluru]

@seaona, I closed the ticket with the above-mentioned PR. Could you please confirm if that is correct? Also, looking at this PR https://github.com/MetaMask/metamask-extension/pull/27928 it seems to have fixed anti-patterns. I actually noticed this flaky test last week as well. Here is another ticket I created last week: https://github.com/MetaMask/metamask-extension/issues/28264, and I have started the analysis.