MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.96k stars 4.89k forks source link

[Bug]: ppom failing on RC v12.5 - Ethereum Mainnet #27951

Open Unik0rnMaggie opened 21 hours ago

Unik0rnMaggie commented 21 hours ago

Describe the bug

PPOM failing on Ethereum Mainnet

Expected behavior

PPOM alert should work as expected

Screenshots/Recordings

https://github.com/user-attachments/assets/50cefb40-274d-4b5a-a426-e35901d9abf4

Steps to reproduce

  1. go to test Dapp
  2. Switch to Ethereum Mainnet in MetaMask
  3. Trigger any of the following:
Malicious ERC20 transfer (USDC)
Malicious ERC20 Approval (BUSD) 
Malicious Set Approval for All 
Malicious ERC 20 Approval with Odd Hex Data
  1. See error Error validating JSON RPC using PPOM: Error: simulation: fallback: (code: -32000, message: , data: None)

https://github.com/user-attachments/assets/fa49c57f-ab98-4ff2-bb1a-0068d57899fe

Error messages or log output

No response

Detection stage

During release testing

Version

12.5.0

Build type

Other (please specify exactly where you obtained this build in "Additional Context" section)

Browser

Chrome, Firefox

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

Unik0rnMaggie commented 16 hours ago

On Linea network there is no console error, but the malicious transactions are not flagged:

Malicious ERC20 transfer (USDC) - not flagged;
Malicious ERC20 Approval (BUSD) - not flagged;
Malicious Set Approval for All - not flagged
Malicious ERC 20 Approval with Odd Hex Data - not flagged

https://github.com/user-attachments/assets/5bad5945-c904-4c8b-85bc-bca06b784ebe

sleepytanya commented 15 hours ago

@Unik0rnMaggie Linea may not be fully supported yet. I see the same behavior in prod and in RC 12.5.0:

Malicious ERC20 transfer (USDC) - not flagged;
Malicious ERC20 Approval (BUSD) - not flagged;
Malicious Set Approval for All - not flagged
Malicious ERC 20 Approval with Odd Hex Data - not flagged
Sign Permit -not flagged

@bschorchit

sleepytanya commented 15 hours ago

PPOM works for me in the latest build https://github.com/MetaMask/metamask-extension/pull/27411#issuecomment-2421046991

https://github.com/user-attachments/assets/4f3c1f37-d04b-4053-863b-273b73c8da14