MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
11.99k stars 4.91k forks source link

[Bug]: Clicking Send Shows Over 600+ Local Accounts #28053

Open darkwing opened 4 days ago

darkwing commented 4 days ago

Describe the bug

When clicking the "Send" button from the wallet home screen, the screen hangs until the Send page finally loads and suddenly there are 600+ accounts in my MetaMask. The 600+ accounts persist when opening the Accounts Menu as well.

Expected behavior

There should only be the few accounts I had created in the first place.

Screenshots/Recordings

https://github.com/user-attachments/assets/4e09eec1-65c2-4c31-b617-3d709282157f

Steps to reproduce

  1. Click send
  2. (wait for hang to finish)
  3. Scroll to see 600+ accounts

Error messages or log output

No response

Detection stage

During release testing

Version

12.6.0

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

plasmacorral commented 4 days ago

related to profile sync

Prithpal-Sooriya commented 3 days ago

CC @MetaMask/notifications to look into. We have turned off account sync for V12.6.0, this should not appear for this version. We are undergoing QA to ensure that this feature is working as intended.

Prithpal-Sooriya commented 3 days ago

@darkwing

Qs:

  1. Is the SRP used an account shared by other teams?

    • If so then there may have been performance tests done by other teams of adding multiple accounts and this was synced. Meaning as a user who is importing this SRP, of course you would retrieve all the synced accounts - so is functioning as intended.
  2. If not, then we need to investigate and ensure that we aren't arbitrarily adding accounts you have not synced!

hjetpoluru commented 3 days ago

I have removed the label release blocker with the reference to the comment here. I have added sev1- high label