MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
12.08k stars 4.93k forks source link

[Bug]: smartTransaction:showSmartTransactionStatusPage' already pending for origin chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn. Please wait. #28518

Open rkalis opened 1 week ago

rkalis commented 1 week ago

Describe the bug

This bug happens when "smart transactions" are turned on, and multiple transactions are submitted in quick succession. The first one to be submitted will use the "smart transactions" setup as expected. But the second transaction will stall, and ultimately return an RPC error:

smartTransaction:showSmartTransactionStatusPage' already pending for origin chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn. Please wait.

Seemingly, MM does queue up this transaction as it does end up getting confirmed later on, but the application that initiated the transactions will not receive any notice of this. This causes the application that initiated the transaction to report a failed transaction

Expected behavior

I'd expect that MM returns either a failure when the transaction could not be submitted or a success response when it can be. Rather than MM returning a failure response even though the transaction does end up getting submitted.

Screenshots/Recordings

CleanShot 2024-11-18 at 10 13 01@2x

Steps to reproduce

This issue can be reproduced on any website that submits multiple transactions, such as Revoke.cash's batch revoke functionality.

Prerequisites:

Steps to reproduce:

  1. Go to Revoke.cash and connect your MM wallet
  2. Select multiple token approvals to revoke and click "Revoke selected"
  3. Select "No tip" and click "Revoke"
  4. Accept the transactions in your MM wallet

Error messages or log output

No response

Detection stage

In production (default)

Version

12.5.1

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

DanielTech21 commented 1 week ago

Hi @rkalis

Thank you for bringing this to our attention.

Our team will look into this.

Thank you!