MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
12.07k stars 4.93k forks source link

fix: fix account list item for portfolio view #28598

Closed sahar-fehri closed 1 day ago

sahar-fehri commented 1 day ago

Description

Fixes account list item wit Portfolio view feature flag.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/metamask-extension/issues/28592

Manual testing steps

Make sure you run the steps with AND without the PORTFOLIO_VIEW flag

  1. Go to settings => Security and privacy => and disable "Show balance and token price checker"
  2. Open account picker make sure you see crypto values
  3. Enable the setting again and you should see Fiat values

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions[bot] commented 1 day ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot commented 1 day ago
Builds ready [7019e84]
Page Load Metrics (1899 ± 98 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint16052319189919392
domContentLoaded15962223186317684
load16052334189920498
domInteractive27107502311
backgroundConnect10194404321
firstReactRender643181395527
getState4124162713
initialActions01000
loadScripts11571687137715072
setupStore584192512
uiStartup177730012186319153
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)
salimtb commented 1 day ago

QA done , works as expected , LGTM

Unik0rnMaggie commented 1 day ago

Confirming the fix works for both account selector and send flow.

Screenshot 2024-11-21 at 12 39 20 Screenshot 2024-11-21 at 12 39 56 Screenshot 2024-11-21 at 12 41 31