MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
12.07k stars 4.93k forks source link

fix: fix test networks display for portfolio view #28601

Closed sahar-fehri closed 22 hours ago

sahar-fehri commented 1 day ago

Description

This PR fixes the display in the asset page and in the main token list when the price checker setting is off

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/metamask-extension/issues/28594

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

https://github.com/user-attachments/assets/a1213b6a-3f23-49f5-be15-a0b369b9016e

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions[bot] commented 1 day ago

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot commented 1 day ago
Builds ready [5430f87]
Page Load Metrics (2107 ± 80 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27825512019433208
domContentLoaded17762486206216077
load18022555210716780
domInteractive23105482110
backgroundConnect8122523617
firstReactRender582941174823
getState691242210
initialActions01000
loadScripts12931958151815374
setupStore66220199
uiStartup200027992366215103
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 8.14 KiB (0.11%)
  • common: 1.85 KiB (0.02%)
metamaskbot commented 1 day ago
Builds ready [c8e2452]
Page Load Metrics (1797 ± 83 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint19522651720390187
domContentLoaded14782181175315675
load15492282179717383
domInteractive14109372211
backgroundConnect8148493818
firstReactRender6355414411053
getState4143283517
initialActions01000
loadScripts10551668128813565
setupStore575172311
uiStartup183427172094255123
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 9.14 KiB (0.12%)
  • common: 1.85 KiB (0.02%)
metamaskbot commented 23 hours ago
Builds ready [a2c3a7d]
Page Load Metrics (1994 ± 75 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint17802337199914771
domContentLoaded17582313196314771
load17622381199415575
domInteractive23493273
backgroundConnect117031199
firstReactRender971731272110
getState65618189
initialActions00000
loadScripts12481795145212359
setupStore664212211
uiStartup20022571223415675
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 940 Bytes (0.01%)
  • common: 0 Bytes (0.00%)