MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
12.07k stars 4.93k forks source link

[Bug]: Confirmations - Address icons are displayed as JazzIcons in Signatures/Transactions despite having Blockies option selected #28609

Open seaona opened 1 day ago

seaona commented 1 day ago

Describe the bug

Address icons are displayed as JazzIcons in Signatures/Transactions despite having Blockies option selected

Expected behavior

No response

Screenshots/Recordings

See how the Account icon is displayed in Blockies (Expected) but the addresses inside the Confirmation Signature/Transaction are displayed in JAzzicons

Screenshot from 2024-11-21 12-57-34

Screenshot from 2024-11-21 12-57-48

Steps to reproduce

  1. Go to settings
  2. [Update] Disable Nicknames --> this is needed to reproduce the bug
  3. Select Blockies icons
  4. Trigger a signature or contract interaction
  5. See the addresses there are displayed in Jazzicons

Error messages or log output

No response

Detection stage

In production (default)

Version

12.6.2

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

Severity

No response

digiwand commented 1 day ago

possibly related to recent asset team changes

OGPoyraz commented 8 hours ago

Hey @seaona ! I can see it works as expected. Can you help me to identify what am I doing wrong here to replicate this bug?

https://github.com/user-attachments/assets/f33acbff-6eb8-4c37-acad-f865617bafce

seaona commented 7 hours ago

okay so I think this only happens if we already have the icon loaded (not the question mark ?), meaning, this would happen with Nicknames disabled from Experimental settings. Could you try to disable Nicknames and then trigger a permit function and see the details, for example? Let me know if this makes it repro on your end :pray: @OGPoyraz