MetaMask / metamask-extension

:globe_with_meridians: :electric_plug: The MetaMask browser extension enables browsing Ethereum blockchain enabled websites
https://metamask.io
Other
12.07k stars 4.93k forks source link

[Bug]: Send to ENS emojis domain - Wrong handling of emojis ENS domains #28610

Open seaona opened 4 days ago

seaona commented 4 days ago

Describe the bug

Whenever we try to perform a send tx to an address with an ENS domain which uses emojis, like πŸ˜‰οΈπŸ˜‰οΈπŸ˜‰οΈ.eth with Nicknames disabled, we can see in 2 places how this is not correctly handled:

Expected behavior

I think for the old transaction screens, that could be left unfixed, since this will be fixed in the new redesigned screens. For the transactions details, once that tx has been send, the recipient should be fixed.

Screenshots/Recordings

In the Transaction receipt, I can see the wrong "parsing" of that ENS domain:

Screenshot from 2024-11-21 13-25-35

In the non redesign transactions, I can also see the wrong parsing in the last Confirmation screen:

https://github.com/user-attachments/assets/c64e7b9e-43d5-4b8a-aa52-e032c6aaafd2

Steps to reproduce

  1. Disable allow nicknames from experimental settings
  2. Disable Improved Transaction Requests from experimental settings
  3. Start a send to this account `0x02d8B596130Fc2d8263d32F4f08a92d1761f2e86
  4. See how in the last confirmation page is displayed xn-n28haa.eth
  5. Enable Improved Transaction REquests
  6. Perform a complete send flow
  7. Wait until tx is confirmed
  8. Check tx receipt info --> see how recipient is xn-n28haa.eth

Error messages or log output

No response

Detection stage

In production (default)

Version

12.6.2

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

Severity

No response